If there was only one entry (the current page) in the page history,
showPrevious() would just reload that page and not return false like
supposed to when no history movement was done.
When forgetting a room in those circumstances, this would also prevent
the switch to the "secret default page" and just leave the user on a
loading spinner for a room that didn't exist anymore.
Rather than leaving the room as soon as the button is clicked.
This offers the option of also forgetting that room, and will allow
checking a future "ignore inviter" too.
AddChat and AccountSettings:
- When clicking the cancel button, if there's no previous back to go
back to, focus the main pane instead of doing nothing
AccountSettings:
- Always enable the cancel button, not just when the form has been
modified
AddChat, AccountSettings, ServerBrowser:
- Pressing escape will do the same thing as clicking the cancel button
In "mobile mode" where main pane is hidden due to application's width:
- Show a back button in the tab bar of the AccountSettings and
AddChat pages
- Show a back button in the address field (opposite to the "next
button") of the ServerBrowser, unless there are no accounts added yet
(application first run) and the main pane would be empty
Go to the corresponding account settings instead of trying to focus the
first room of the target account if there is one.
This makes the behavior consistent across expanded and collapsed
accounts, and with the Keys.Account.(previous/next) keybinds that
were changed to work in this way in commit
4f4bc90faa.
Instantiator is better suited to the task: Repeater is specially
made to load visual components, and that forced us to wrap the
HShortcuts inside empty Items.
On startup, there will be one page in the history, not zero.
Disable history navigation in such cases where the current page will
just get selected again.
* Add keys for back and forward through history
Move through history of visited rooms without altering it.
Ctrl+H and Ctrl+Y by default.
Deviating from history while in the middle of it
causes a part of history to be discarded.
* Change default history binding to Ctrl+H and Ctrl+Shift+H
* Rename functions and settings
`earlier_page` and `later_page` is consistent naming with `last_page`
* Add option to wrap history
If you press `later_page` while at index 0 (newest), you loop to the end
of recorded history (oldest). If you press `earlier_page` while at at
the end of history (oldest), you loop back to the top (newest).
This can be disabled.
* Add showNthFromHistory
Grouped duplicated code into a new funcion.
* Minor formatting changes
* Move wrap_history setting from to General section
The Keys section is purely for keybindings; this setting should also be
able to control history navigation not done by keyboard such as extra
mouse button bindings.
* Change default bind for later_page and clear_all
Ctrl+H and Ctrl+L are a more intuitive pair than Ctrl+H and Ctrl+Shift+H.
Meanwhile, clear_all does not need the accessible binding Ctrl+L.
Co-authored-by: miruka <miruka@disroot.org>
* Add keybinding for quit
* Reorder default settings
The related keybindings are now located closer together.
quit is not commented by default, but instead has an empty list.
* No need for braces for a single instruction
When the currently shown page is the chat of a certain room,
prevent that room from moving around in the left pane due to new
messages/activity or unread/highlight counters change.
When the user switches to another page/room, the previously held lock is
released and that room completes all the moves it would have done if it
wasn't locked.
This makes navigating a room list with lots of activity easier, and
prevent annoyances like clicking on a room with unread messages and
having it immediatly fly down the list (possibly out of scroll view).
This reverts commit 39f159f0a3.
Causes problems when message delegates are reordered, with the
transition animations randomly stopping in the middle and leaving
delegates at odd positions.
Alt+M: toggle "mute all notifications except highlights"
Alt+Shift+M: toggle "mute all notifications"
The Keys.Rooms.(previous/next)_highlight keybinds, previously bound to
Alt+(Shift+)M (stood for "mention") now defaults to Alt+(Shift+)H.
The NotificationLevel enum and notificationLevel property had to be
moved from Window to UI due to QML having a global "Window" object that
causes conflicts when trying to access the enum as
"Window.NotificationLevel" from UI.qml.
- More descriptive menu entries
- Indicate the current setting in the menu with a checkmark
- Remove menu button tooltip that gets in the way
- Remove unused icon
Pin/unpin is more representative of what the function actually does
for rooms in the left pane. Also change the corresponding icons and
renames the config file section: RoomList.Bookmarks → RoomList.Pinned
In the notification push rules UI:
- When the notify button for a rule (blue +1) is toggled off, show
all other action buttons as toggled off too
- When clicking on another action while notify is off, enable notify and
that action
Add RoomList.local_unread_markers option to settings.py,
which is False by default.
Before, this way always enabled and conflicts with push rules by marking
anything as unread without any logic.
When clicking on an account in the top account bar or using the
Keys.Account.(previous/next) keybinds, go to the corresponding
account settings instead of trying to focus the first room of that
account if there is one: user might not want to clear the read marker of
any random room that is out of view and happens to be the first in the
list.
- Notifications.alert_time → Notifications.flash_time,
more evocative of what these "alerts" actually do
- Change default for the above from 0 to 5, since now push rules already
control precisely what to enable or disable these alerts for
- Notifications.urgent_alert_time → Notifications.highlight_flash_time,
"highlight" is the term used in the matrix doc
Fix refresh and sign out keybinds that were broken, and rename
these in settings.py:
- Keys.Sessions.refresh → Keys.Security.refresh
- Keys.Sessions.sign_out_checked_or_all → Keys.Security.sign_out
Downloading file messages will now show a transfer control above the
composer, similar to uploads. Measuring the progress or pausing the
operation is not possible yet.
