Customize check mark for checkable menu items

docs/TODO.md

@@ -5,7 +5,6 @@
 - combo box custom item
 - explain pattern
 - fix spinbox buttons
-- HMenuItem checkbox styling
 - quick settings
 - import/export/json edit rules?
 - fix flickable popups can't be flicked by keyboard

src/gui/Base/HMenuItem.qml

@@ -33,6 +33,14 @@ MenuItem {
         buttonTheme: theme.controls.menuItem
         label.horizontalAlignment: Label.AlignLeft
 
+        HIcon {
+            visible: menuItem.checkable
+            opacity: menuItem.checked ? 1 : 0
+            svgName: "menu-item-check-mark"
+
+            Behavior on opacity { HNumberAnimation {} }
+        }
+
         HIcon {
             visible: menuItem.subMenu
             svgName: "submenu-arrow"
@@ -40,4 +48,5 @@ MenuItem {
     }
 
     arrow: null
+    indicator: null
 }

src/gui/MainPane/RoomDelegate.qml

@@ -152,6 +152,7 @@ HTile {
 
             HMenuItem {
                 text: qsTr("Use default account settings")
+                checkable: true
                 checked: model.notification_setting === "UseDefaultSettings"
                 onTriggered: py.callClientCoro(
                     model.for_account, "room_pushrule_use_default", [model.id],
@@ -160,6 +161,7 @@ HTile {
 
             HMenuItem {
                 text: qsTr("All new messages")
+                checkable: true
                 checked: model.notification_setting === "AllEvents"
                 onTriggered: py.callClientCoro(
                     model.for_account, "room_pushrule_all_events", [model.id],
@@ -168,6 +170,7 @@ HTile {
 
             HMenuItem {
                 text: qsTr("Highlights only (replies, keywords...)")
+                checkable: true
                 checked: model.notification_setting === "HighlightsOnly"
                 onTriggered: py.callClientCoro(
                     model.for_account,
@@ -178,6 +181,7 @@ HTile {
 
             HMenuItem {
                 text: qsTr("Ignore new messages")
+                checkable: true
                 checked: model.notification_setting === "IgnoreEvents"
                 onTriggered: py.callClientCoro(
                     model.for_account, "room_pushrule_ignore_all", [model.id],

src/gui/MainPane/TopBar.qml

@@ -94,6 +94,7 @@ Rectangle {
 
                 HMenuItem {
                     text: qsTr("Enable notifications")
+                    checkable: true
                     checked:
                         mainUI.notificationLevel ===
                             UI.NotificationLevel.Enable
@@ -104,6 +105,7 @@ Rectangle {
 
                 HMenuItem {
                     text: qsTr("Highlights only (replies, keywords...)")
+                    checkable: true
                     checked:
                         mainUI.notificationLevel ===
                             UI.NotificationLevel.HighlightsOnly
@@ -114,6 +116,7 @@ Rectangle {
 
                 HMenuItem {
                     text: qsTr("Mute all notifications")
+                    checkable: true
                     checked:
                         mainUI.notificationLevel === UI.NotificationLevel.Mute
                     onTriggered:

src/icons/thin/menu-item-check-mark.svg

@@ -0,0 +1,3 @@
+<svg clip-rule="evenodd" fill-rule="evenodd" height="24" width="24" xmlns="http://www.w3.org/2000/svg">
+    <path d="m21 6.285-11.16 12.733-6.84-6.018 1.319-1.49 5.341 4.686 9.865-11.196z"/>
+</svg>