From e8b8509d2240203a53cf4e20fa8de1ccac566654 Mon Sep 17 00:00:00 2001
From: miruka <miruka@disroot.org>
Date: Mon, 22 Feb 2021 11:43:51 -0400
Subject: [PATCH] Open settings popup on pushrule delegate click

---
 docs/TODO.md                                           |  1 -
 .../Pages/AccountSettings/NotificationRuleDelegate.qml | 10 ++++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/docs/TODO.md b/docs/TODO.md
index 2066a1b9..1990f517 100644
--- a/docs/TODO.md
+++ b/docs/TODO.md
@@ -1,6 +1,5 @@
 # TODO
 
-- right click on rule
 - combo box custom item
 - explain pattern
 - fix spinbox buttons
diff --git a/src/gui/Pages/AccountSettings/NotificationRuleDelegate.qml b/src/gui/Pages/AccountSettings/NotificationRuleDelegate.qml
index c05e8f53..471690be 100644
--- a/src/gui/Pages/AccountSettings/NotificationRuleDelegate.qml
+++ b/src/gui/Pages/AccountSettings/NotificationRuleDelegate.qml
@@ -95,11 +95,13 @@ HTile {
 
             NotificationRuleButton {
                 icon.name: "pushrule-edit"
-                onClicked: window.makePopup(
-                    "Popups/PushRuleSettingsPopup/PushRuleSettingsPopup.qml",
-                    {userId: page.userId, rule: model},
-                )
+                onClicked: root.clicked()
             }
         }
     }
+
+    onClicked: window.makePopup(
+        "Popups/PushRuleSettingsPopup/PushRuleSettingsPopup.qml",
+        {userId: page.userId, rule: model},
+    )
 }