Page & popups: standardized keyboard accept/cancel

TODO.md

@@ -10,7 +10,7 @@
 - can leave room with a reason?
 - field/area focus line in popups weird
 - use new nio `restore_login()`
-- verify all popups and boxes work
+- verify all popups and boxes work: enter/esc, tab focus, operations
 
 ## Refactoring
 

src/gui/Base/HBox.qml

@@ -7,10 +7,6 @@ HFlickableColumnPage {
     implicitWidth: Math.min(parent.width, theme.controls.box.defaultWidth)
     implicitHeight: Math.min(parent.height, flickable.contentHeight)
 
-    // XXX
-    // Keys.onReturnPressed: if (clickButtonOnEnter) enterClickButton()
-    // Keys.onEnterPressed: Keys.onReturnPressed(event)
-
     background: Rectangle {
         color: theme.controls.box.background
         radius: theme.controls.box.radius

src/gui/Base/HPage.qml

@@ -7,6 +7,10 @@ Page {
     padding: currentSpacing < theme.spacing ? 0 : currentSpacing
     background: null
 
+    Keys.onReturnPressed: keyboardAccept()
+    Keys.onEnterPressed: keyboardAccept()
+    Keys.onEscapePressed: keyboardCancel()
+
 
     property bool useVariableSpacing: true
 
@@ -19,6 +23,9 @@ Page {
         ) :
         theme.spacing
 
+    signal keyboardAccept()
+    signal keyboardCancel()
+
 
     Behavior on padding { HNumberAnimation {} }
 }

src/gui/Pages/AccountSettings/Account.qml

@@ -87,7 +87,8 @@ HFlickableColumnPage {
         }
     }
 
-    Keys.onEscapePressed: cancel()
+    onKeyboardCancel: cancel()
+    onKeyboardAccept: applyChanges()
 
 
     HUserAvatar {
@@ -221,8 +222,6 @@ HFlickableColumnPage {
 
             // TODO: Qt 5.14+: use a Binding enabled when text not empty
             color: utils.nameColor(text)
-
-            onAccepted: applyChanges()
         }
     }
 
@@ -262,7 +261,6 @@ HFlickableColumnPage {
         HTextField {
             width: parent.width
             error: aliasField.alreadyTakenBy !== ""
-            onAccepted: applyChanges()
             defaultText: aliasField.currentAlias
             placeholderText: qsTr("e.g. %1").arg((
                 nameField.item.text ||

src/gui/Pages/AddAccount/SignIn.qml

@@ -92,7 +92,7 @@ HFlickableColumnPage {
         }
     }
 
-    Keys.onEscapePressed: page.cancel()
+    onKeyboardCancel: page.cancel()
 
 
     Timer {

src/gui/Pages/AddChat/CreateRoom.qml

@@ -64,7 +64,7 @@ HFlickableColumnPage {
         }
     }
 
-    Keys.onEscapePressed: cancel()
+    onKeyboardCancel: cancel()
 
 
     HRoomAvatar {

src/gui/Pages/AddChat/DirectChat.qml

@@ -81,7 +81,7 @@ HFlickableColumnPage {
         }
     }
 
-    Keys.onEscapePressed: cancel()
+    onKeyboardCancel: cancel()
 
 
     CurrentUserAvatar {

src/gui/Pages/AddChat/JoinRoom.qml

@@ -69,7 +69,7 @@ HFlickableColumnPage {
         }
     }
 
-    Keys.onEscapePressed: cancel()
+    onKeyboardCancel: cancel()
 
 
     CurrentUserAvatar {

src/gui/Pages/Chat/RoomPane/SettingsView.qml

@@ -79,7 +79,8 @@ HFlickableColumnPage {
         }
     }
 
-    Keys.onEscapePressed: cancel()
+    onKeyboardAccept: save()
+    onKeyboardCancel: cancel()
 
 
     HRoomAvatar {

src/gui/Popups/HColumnPopup.qml

@@ -10,6 +10,8 @@ HPopup {
     default property alias pageData: page.columnData
     readonly property alias page: page
 
+    signal keyboardAccept()
+
 
     HColumnPage {
         id: page
@@ -23,5 +25,8 @@ HPopup {
             topPadding + bottomPadding + implicitContentHeight,
         )
         useVariableSpacing: false
+
+        Keys.onReturnPressed: popup.keyboardAccept()
+        Keys.onEnterPressed: popup.keyboardAccept()
     }
 }

src/gui/Popups/HFlickableColumnPopup.qml

@@ -10,6 +10,8 @@ HPopup {
     default property alias pageData: page.columnData
     readonly property alias page: page
 
+    signal keyboardAccept()
+
 
     HFlickableColumnPage {
         id: page
@@ -21,5 +23,8 @@ HPopup {
             popup.maximumPreferredHeight,
             implicitHeaderHeight + implicitFooterHeight + contentHeight,
         )
+
+        Keys.onReturnPressed: popup.keyboardAccept()
+        Keys.onEnterPressed: popup.keyboardAccept()
     }
 }

src/gui/Popups/PasswordPopup.qml

@@ -74,6 +74,7 @@ HFlickableColumnPopup {
     }
 
     onOpened: passwordField.forceActiveFocus()
+    onKeyboardAccept: popup.validate()
 
 
     SummaryLabel { id: summary }
@@ -90,8 +91,6 @@ HFlickableColumnPopup {
             onTextChanged: passwordValid =
                 validateWhileTyping ? verifyPassword(text) : null
 
-            onAccepted: popup.validate()
-
             Layout.fillWidth: true
         }
 

src/gui/Popups/RedactPopup.qml

@@ -51,6 +51,7 @@ HFlickableColumnPopup {
     }
 
     onOpened: reasonField.item.forceActiveFocus()
+    onKeyboardAccept: popup.remove()
 
 
     SummaryLabel {
@@ -80,7 +81,6 @@ HFlickableColumnPopup {
 
         HTextField {
             width: parent.width
-            onAccepted: popup.remove()
         }
     }
 }

src/gui/Popups/RemoveMemberPopup.qml

@@ -48,6 +48,7 @@ HFlickableColumnPopup {
     }
 
     onOpened: reasonField.item.forceActiveFocus()
+    onKeyboardAccept: popup.remove()
 
 
     SummaryLabel {
@@ -70,7 +71,6 @@ HFlickableColumnPopup {
 
         HTextField {
             width: parent.width
-            onAccepted: popup.remove()
         }
     }
 }