From dc2a7b8ee1e747a58a7cfa87a102d14d1495fd05 Mon Sep 17 00:00:00 2001 From: miruka Date: Thu, 9 Jul 2020 13:13:17 -0400 Subject: [PATCH] HMenuItem: always use onTriggered, not onClicked --- TODO.md | 3 +-- src/gui/MainPane/AccountContextMenu.qml | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/TODO.md b/TODO.md index f239879a..d3975783 100644 --- a/TODO.md +++ b/TODO.md @@ -3,8 +3,7 @@ - fix highlight when logging in to new account - warn about no E2E room shared if no devices - keyboard controls -- HTile enter trigger leftClicked() -- HMenuItem: use onTriggered, not onClicked +- Make HTile enter key trigger leftClicked() ## Refactoring diff --git a/src/gui/MainPane/AccountContextMenu.qml b/src/gui/MainPane/AccountContextMenu.qml index 5102f685..f821ce31 100644 --- a/src/gui/MainPane/AccountContextMenu.qml +++ b/src/gui/MainPane/AccountContextMenu.qml @@ -11,7 +11,7 @@ HMenu { HMenuItem { icon.name: "account-settings" text: qsTr("Account settings") - onClicked: pageLoader.showPage( + onTriggered: pageLoader.showPage( "AccountSettings/AccountSettings", { "userId": userId }, ) } @@ -19,7 +19,7 @@ HMenu { HMenuItem { icon.name: "menu-add-chat" text: qsTr("Add new chat") - onClicked: pageLoader.showPage("AddChat/AddChat", {userId: userId}) + onTriggered: pageLoader.showPage("AddChat/AddChat", {userId: userId}) } HMenuItem {