Zergling_man/moment
Zergling_man/moment
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace assert statements by normal if/raise

Browse Source
This commit is contained in:
miruka 2019-04-22 10:08:42 -04:00
parent 98969b75c7
commit d47bf34522
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
harmonyqml/backend/model/list_model.py
View File

@ -78,8 +78,10 @@ class ListModel(QAbstractListModel):
def _convert_new_value(self, value: NewItem) -> ListItem: def _convert_new_value(self, value: NewItem) -> ListItem:
def convert() -> ListItem: def convert() -> ListItem:
if self._data and isinstance(value, Mapping): if self._data and isinstance(value, Mapping):
assert set(value.keys()) <= set(self.roles), \ if not set(value.keys()) <= set(self.roles):
raise ValueError(
f"{value}: must have all these keys: {self.roles}" f"{value}: must have all these keys: {self.roles}"
)
return type(self._data[0])(**value) return type(self._data[0])(**value)

3
harmonyqml/backend/signal_manager.py
View File

@ -124,7 +124,8 @@ class SignalManager(QObject):
inviter: Inviter = None, inviter: Inviter = None,
left_event: LeftEvent = None) -> None: left_event: LeftEvent = None) -> None:
assert not (inviter and left_event) if (inviter and left_event):
raise ValueError()
model = self.backend.models.rooms[client.userId] model = self.backend.models.rooms[client.userId]
no_update = [] no_update = []