Replace assert statements by normal if/raise

2019-04-22 10:08:42 -04:00
parent 98969b75c7
commit d47bf34522
2 changed files with 6 additions and 3 deletions
--- a/harmonyqml/backend/model/list_model.py
+++ b/harmonyqml/backend/model/list_model.py
@@ -78,8 +78,10 @@ class ListModel(QAbstractListModel):
    def _convert_new_value(self, value: NewItem) -> ListItem:
        def convert() -> ListItem:
            if self._data and isinstance(value, Mapping):
-                assert set(value.keys()) <= set(self.roles), \
-                       f"{value}: must have all these keys: {self.roles}"
+                if not set(value.keys()) <= set(self.roles):
+                    raise ValueError(
+                        f"{value}: must have all these keys: {self.roles}"
+                    )

                return type(self._data[0])(**value)