Zergling_man/moment
Zergling_man/moment
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable buggy composer backspace override

Browse Source
This commit is contained in:
miruka 2020-03-09 08:09:58 -04:00
parent 0fa16400df
commit ca8dd65f34
2 changed files with 24 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
TODO.md
View File

@ -1,12 +1,16 @@
# TODO # TODO
## Before release
- "exception during sync" aren't caught - "exception during sync" aren't caught
- nio ClientTimeout
- Handle upload file size limit
- Update docstrings
- Update TODO.md
- Update README.md
## Media ## Media
- nio ClientTimeout
- Handle upload file size limit
- Handle set avatar upload errors - Handle set avatar upload errors
- Confirmation box after picking file to upload - Confirmation box after picking file to upload
- Show real progression for mxc thumbnail loadings - Show real progression for mxc thumbnail loadings
@ -44,6 +48,7 @@
- Forget a room, it comes back because of the "you left" event - Forget a room, it comes back because of the "you left" event
- `EventImage`s for `m.image` sometimes appear broken, can be made normal - `EventImage`s for `m.image` sometimes appear broken, can be made normal
by switching to another room and coming back by switching to another room and coming back
- First sent message in E2E room is sometimes undecryptable - First sent message in E2E room is sometimes undecryptable
- Pausing uploads doesn't work well, servers end up dropping the connection - Pausing uploads doesn't work well, servers end up dropping the connection
@ -53,10 +58,8 @@
- Ensure all the text that should be copied is copied - Ensure all the text that should be copied is copied
- Multiple messages are currently copied out of order - Multiple messages are currently copied out of order
- Pressing backspace in composer sometimes doesn't work
- `code` not colored in room subtitle - `code` not colored in room subtitle
- Quote links color in room subtitles (e.g. "> http://foo.orgA)" ) - Quote links color in room subtitles (e.g. "> http://foo.org" )
- If account not in config anymore, discard ui state last page on startup - If account not in config anymore, discard ui state last page on startup
- Do something when access token is invalid - Do something when access token is invalid
@ -205,8 +208,6 @@
## Distribution & dependencies ## Distribution & dependencies
- Mistune v2.0 - Mistune v2.0
- Include python dependencies in binary with rcc?
- Improve the README.md
## Notable changes for future Qt version upgrade ## Notable changes for future Qt version upgrade

29
src/gui/Pages/Chat/Composer.qml
View File

@ -45,10 +45,10 @@ Rectangle {
readonly property string lineTextUntilCursor: readonly property string lineTextUntilCursor:
lineText.substring(0, cursorX) lineText.substring(0, cursorX)
readonly property int deleteCharsOnBackspace: // readonly property int deleteCharsOnBackspace:
lineTextUntilCursor.match(/^ +$/) ? // lineTextUntilCursor.match(/^ +$/) ?
lineTextUntilCursor.match(/ {1,4}/g).slice(-1)[0].length : // lineTextUntilCursor.match(/ {1,4}/g).slice(-1)[0].length :
1 // 1
function takeFocus() { areaScrollView.forceActiveFocus() } function takeFocus() { areaScrollView.forceActiveFocus() }
@ -199,16 +199,17 @@ Rectangle {
return return
} }
if (ev.modifiers === Qt.NoModifier && // FIXME: buggy
ev.key === Qt.Key_Backspace && // if (ev.modifiers === Qt.NoModifier &&
! textArea.selectedText) // ev.key === Qt.Key_Backspace &&
{ // ! textArea.selectedText)
ev.accepted = true // {
textArea.remove( // ev.accepted = true
cursorPosition - deleteCharsOnBackspace, // textArea.remove(
cursorPosition // cursorPosition - deleteCharsOnBackspace,
) // cursorPosition
} // )
// }
}) })
} }
} }