Zergling_man/moment
Zergling_man/moment
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ignore offline presence updates for our account

Browse Source 
If another client becomes invisible/offline or we stop syncing for some
time (due to e.g. connection issue or debugger freeze), the server will
tell us our presence is offline. Following this update would lead to our
our current connection being terminated, so ignore it.

Side-effect: if we become invisible and another client with this behavior
is using the account at the same time, this will result in us becoming
online/unavailable again a few seconds later, since we follow
updates for these status to avoid conflicts
This commit is contained in:
miruka 2021-04-16 09:51:36 -04:00
parent 93505dc44f
commit c1f5605c1c
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/nio_callbacks.py
View File

@ -902,7 +902,7 @@ class NioCallbacks:
# If presence event represents a change for one of our account
if account and account.presence != Presence.State.offline:
# Ignore cases where we send a new presence to the server, but it
# returns an older state that doesn't match due to lag
# returns an older state that doesn't match due to lag:
if (
account.presence == Presence.State.echo_invisible and
ev.presence != Presence.State.offline.value
@ -915,8 +915,13 @@ class NioCallbacks:
):
return
# Do not fight back presence from other clients
self.client.backend.clients[ev.user_id]._presence = ev.presence
# Do not fight back presence from other clients, unless server says
# we're offline, which happens if another client disconnected or we
# had a long connection issue. Note that this makes invisibility
# only possible if we're the only client using the account, or the
# other clients are invisible/offline themselves.
if ev.presence != Presence.State.offline.value:
self.client.backend.clients[ev.user_id]._presence = ev.presence
# Restore status msg lost from server due to e.g. getting offline
if not ev.status_msg and account.status_msg:
@ -924,7 +929,7 @@ class NioCallbacks:
ev.presence, account.status_msg,
)
# Save the presence for the next resume
# Save the presence to be restored next time we restart application
if account.save_presence:
status_msg = presence.status_msg
state = presence.presence