Zergling_man/moment
Zergling_man/moment
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove account collapse bug workaround

Browse Source 
Unable to reproduce the bug where collapsing an account with lots of
rooms corrupts the ListView, did updating to Qt 5.14.2 do something?

With the workaround removed, the 0.2s delay when removing batch of
ListView items (e.g. when filtering) is gone.
This commit is contained in:
miruka 2020-05-30 18:40:58 -04:00
parent de894ab4bb
commit b399de6776
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/models/model.py
View File

@ -1,7 +1,6 @@
# SPDX-License-Identifier: LGPL-3.0-or-later # SPDX-License-Identifier: LGPL-3.0-or-later
import itertools import itertools
import time
from bisect import bisect from bisect import bisect
from contextlib import contextmanager from contextlib import contextmanager
from threading import RLock from threading import RLock
@ -194,22 +193,13 @@ class Model(MutableMapping):
yield None yield None
finally: finally:
indice = self._active_batch_remove_indice indice = self._active_batch_remove_indice
groups = [list(group) for item, group in itertools.groupby(indice)] groups = [
last = None list(group) for item, group in itertools.groupby(indice)
]
if groups:
last = groups[-1].pop()
if not groups[-1]:
del groups[-1]
for grp in groups: for grp in groups:
ModelItemDeleted(self.sync_id, index=grp[0], count=len(grp)) ModelItemDeleted(
self.sync_id, index=grp[0], count=len(grp),
# Seems QML ListView has an horrible bug where removing a large )
# amount of items at once will result in a corrupted empty display,
# this dumb workaround is the only way I've found
if last:
time.sleep(0.2)
ModelItemDeleted(self.sync_id, index=last, count=1)
self._active_batch_remove_indice = None self._active_batch_remove_indice = None