Lock position of the room that's focused in GUI

When the currently shown page is the chat of a certain room,
prevent that room from moving around in the left pane due to new
messages/activity or unread/highlight counters change.

When the user switches to another page/room, the previously held lock is
released and that room completes all the moves it would have done if it
wasn't locked.

This makes navigating a room list with lots of activity easier, and
prevent annoyances like clicking on a room with unread messages and
having it immediatly fly down the list (possibly out of scroll view).
This commit is contained in:
miruka
2021-03-02 08:53:50 -04:00
parent 3f88a2204e
commit 902f13ab68
4 changed files with 67 additions and 17 deletions

View File

@@ -183,6 +183,15 @@ class Room(ModelItem):
lexical_sorting: bool = False
pinned: bool = False
# Allowed keys: "last_event_date", "unreads", "highlights", "local_unreads"
# Keys in this dict will override their corresponding item fields for the
# __lt__ method. This is used when we want to lock a room's position,
# e.g. to avoid having the room move around when it is focused in the GUI
_sort_overrides: Dict[str, Any] = field(default_factory=dict)
def _sorting(self, key: str) -> Any:
return self._sort_overrides.get(key, getattr(self, key))
def __lt__(self, other: "Room") -> bool:
by_activity = not self.lexical_sorting
@@ -191,10 +200,10 @@ class Room(ModelItem):
other.pinned,
self.left, # Left rooms may have an inviter_id, check them first
bool(other.inviter_id),
bool(by_activity and other.highlights),
bool(by_activity and other.unreads),
bool(by_activity and other.local_unreads),
other.last_event_date if by_activity else ZERO_DATE,
bool(by_activity and other._sorting("highlights")),
bool(by_activity and other._sorting("unreads")),
bool(by_activity and other._sorting("local_unreads")),
other._sorting("last_event_date") if by_activity else ZERO_DATE,
(self.display_name or self.id).lower(),
self.id,
@@ -203,10 +212,10 @@ class Room(ModelItem):
self.pinned,
other.left,
bool(self.inviter_id),
bool(by_activity and self.highlights),
bool(by_activity and self.unreads),
bool(by_activity and self.local_unreads),
self.last_event_date if by_activity else ZERO_DATE,
bool(by_activity and self._sorting("highlights")),
bool(by_activity and self._sorting("unreads")),
bool(by_activity and self._sorting("local_unreads")),
self._sorting("last_event_date") if by_activity else ZERO_DATE,
(other.display_name or other.id).lower(),
other.id,
)
@@ -233,10 +242,10 @@ class AccountOrRoom(Account, Room):
other.pinned,
self.left,
bool(other.inviter_id),
bool(by_activity and other.highlights),
bool(by_activity and other.unreads),
bool(by_activity and other.local_unreads),
other.last_event_date if by_activity else ZERO_DATE,
bool(by_activity and other._sorting("highlights")),
bool(by_activity and other._sorting("unreads")),
bool(by_activity and other._sorting("local_unreads")),
other._sorting("last_event_date") if by_activity else ZERO_DATE,
(self.display_name or self.id).lower(),
self.id,
@@ -247,10 +256,10 @@ class AccountOrRoom(Account, Room):
self.pinned,
other.left,
bool(self.inviter_id),
bool(by_activity and self.highlights),
bool(by_activity and self.unreads),
bool(by_activity and self.local_unreads),
self.last_event_date if by_activity else ZERO_DATE,
bool(by_activity and self._sorting("highlights")),
bool(by_activity and self._sorting("unreads")),
bool(by_activity and self._sorting("local_unreads")),
self._sorting("last_event_date") if by_activity else ZERO_DATE,
(other.display_name or other.id).lower(),
other.id,
)