Fix QML Connections-using code for Qt 5.12

CHANGELOG.md

@@ -15,6 +15,8 @@ and this project adheres to
 - Fix checkboxes in the room settings not having their default values updated
   after switching room
 
+- Fix various minor features broken on Qt 5.12 and the AppImage since v0.5.2
+
 
 ## 0.6.3 (2020-09-16)
 

src/gui/Base/MediaPlayer/VideoPlayer.qml

@@ -42,8 +42,7 @@ Video {
 
     Connections {
         target: mainUI.fullScreenPopup
-
+        onClosed: fullScreen = false
-        function onClosed() { fullScreen = false }
     }
 
     TapHandler {

src/gui/MainPane/RoomList.qml

@@ -215,8 +215,7 @@ HListView {
 
     Connections {
         target: pageLoader
-
+        onPreviousShown: (componentUrl, properties)  => {
-        function onPreviousShown(componentUrl, properties) {
             if (setCorrectCurrentItem() === false) startCorrectItemSearch()
         }
     }

src/gui/Pages/Chat/AutoCompletion/UserAutoCompletion.qml

@@ -145,7 +145,7 @@ HListView {
     Connections {
         target: root.textArea
 
-        function onCursorPositionChanged() {
+        onCursorPositionChanged: {
             if (! root.open) return
 
             const pos   = root.textArea.cursorPosition
@@ -162,7 +162,7 @@ HListView {
             if (pos < start || pos > end) root.accept()
         }
 
-        function onTextChanged() {
+        onTextChanged: {
             let changed = false
 
             for (const [id, name] of Object.entries(root.usersCompleted)) {

src/gui/Pages/Chat/Chat.qml

@@ -136,7 +136,7 @@ Item {
 
             Connections {
                 target: pageLoader
-                function onRecycled() { roomPane.appearAnimation.restart() }
+                onRecycled: roomPane.appearAnimation.restart()
             }
         }
     }

src/gui/Pages/Chat/Composer/MessageArea.qml

@@ -248,8 +248,7 @@ HTextArea {
 
     Connections {
         target: pageLoader
-
+        onRecycled: {
-        function onRecycled() {
             area.reset()
             area.loadState()
         }

src/gui/Pages/Chat/RoomPane/MemberView/MemberProfile.qml

@@ -307,8 +307,7 @@ HListView {
 
     Connections {
         target: py.eventHandlers
-
+        onDeviceUpdateSignal: forAccount => {
-        function onDeviceUpdateSignal(forAccount) {
             if (forAccount === root.userId) root.loadDevices()
         }
     }

src/gui/Pages/Chat/RoomPane/MemberView/MemberView.qml

@@ -16,8 +16,7 @@ HColumnLayout {
 
     Connections {
         target: pageLoader
-
+        onAboutToRecycle: {
-        function onAboutToRecycle() {
             stackView.pop(stackView.initialItem)
             filterField.reset()
         }
@@ -78,8 +77,7 @@ HColumnLayout {
 
             Connections {
                 target: pageLoader
-
+                onRecycled: {
-                function onRecycled() {
                     memberList.model = null
                     updateModelTimer.restart()
                 }

src/gui/Pages/Chat/RoomPane/RoomPane.qml

@@ -88,18 +88,13 @@ MultiviewPane {
 
     Connections {
         target: swipeView
-
+        onCurrentItemChanged:
-        function onCurrentItemChanged() {
             roomPane.swipeView.currentItem.keybindFocusItem.forceActiveFocus()
-        }
     }
 
     Connections {
         target: pageLoader
-
+        onAboutToRecycle: roomPane.swipeView.currentIndex = 0
-        function onAboutToRecycle() {
-            roomPane.swipeView.currentIndex = 0
-        }
     }
 
     MemberView {}

src/gui/Pages/Chat/RoomPane/SettingsView.qml

@@ -82,7 +82,7 @@ HFlickableColumnPage {
 
     Connections {
         target: pageLoader
-        function onAboutToRecycle() { cancel() }
+        onAboutToRecycle: cancel()
     }
 
     HRoomAvatar {

src/gui/Pages/Chat/Timeline/EventContent.qml

@@ -191,12 +191,8 @@ HRowLayout {
 
             Connections {
                 target: eventList
-
+                onCheckedChanged: contentLabel.deselect()
-                function onCheckedChanged() {
+                onDelegateWithSelectedTextChanged: {
-                    contentLabel.deselect()
-                }
-
-                function onDelegateWithSelectedTextChanged() {
                     if (eventList.delegateWithSelectedText !== model.id)
                         contentLabel.deselect()
                 }

src/gui/Pages/Chat/Timeline/EventList.qml

@@ -576,7 +576,7 @@ Rectangle {
 
         Connections {
             target: pageLoader
-            function onRecycled() { eventList.moreToLoad = true }
+            onRecycled: eventList.moreToLoad = true
         }
     }
 

src/gui/Popups/ConfirmClipboardUploadPopup.qml

@@ -81,10 +81,8 @@ HColumnPopup {
 
         Connections {
             target: Clipboard
-
+            onContentChanged:
-            function onContentChanged() {
                 Clipboard.hasImage ? image.updateCounter += 1 : popup.close()
-            }
         }
     }
 }

src/main.cpp

@@ -40,10 +40,13 @@ void loggingHandler(
     Q_UNUSED(context)
 
     // Hide dumb warnings about thing we can't fix without breaking
-    // compatibilty with Qt < 5.14
+    // compatibilty with Qt < 5.14/5.15
     if (msg.contains("QML Binding: Not restoring previous value because"))
         return;
 
+    if (msg.contains("QML Connections: Implicitly defined onFoo properties"))
+        return;
+
     // Hide layout-related spam introduced in Qt 5.14
     if (msg.contains("Qt Quick Layouts: Detected recursive rearrange."))
         return;