From 4a780e20f43a7e0afeccf0ed35674b135ad0104e Mon Sep 17 00:00:00 2001
From: miruka <miruka@disroot.org>
Date: Thu, 26 Mar 2020 21:55:30 -0400
Subject: [PATCH] Make HMenu modal

Prevents accidentally triggering TapHandlers when clicking outside of
the menu to exit it.
---
 TODO.md                | 13 ++++---------
 src/gui/Base/HMenu.qml |  2 ++
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/TODO.md b/TODO.md
index 8269061c..eb517cf8 100644
--- a/TODO.md
+++ b/TODO.md
@@ -1,14 +1,10 @@
 # TODO
 
-- make it not select messages when closing context menu
-- long-press-drag to select multiple messages on touch
-- drag to select on non-touch
-- shift+click to select everything in between
+- Long-press-drag to select multiple messages on touch
+- Drag to select multiple messages on non-touch
+- Shift+click to select everything in between
 
-- remove radius on invite/left banner
-- side pane back/forward buttons hard to use on touch
-- is it still slow on sway with wayland-egl?
-- room pane drag-scroll a tiny bit activates the delegates
+- Drag-scrolling in room pane a tiny bit activates the delegates
 
 ## Goals before 0.5.0
 
@@ -90,7 +86,6 @@
 - Remember the previously focused item in page for ctrl+tab 
 - https://doc.qt.io/qt-5/qml-qtquick-smoothedanimation.html for progress bars
 - Improve when HDrawer should collapse when the ui is zoomed
-- Way to open context menus without a right mouse button
 - Make room invite/left banner buttons look better
 
 - Choose a better easing types for animations
diff --git a/src/gui/Base/HMenu.qml b/src/gui/Base/HMenu.qml
index 7c8a819f..05ef0a9d 100644
--- a/src/gui/Base/HMenu.qml
+++ b/src/gui/Base/HMenu.qml
@@ -5,6 +5,8 @@ import QtQuick.Controls 2.12
 
 Menu {
     id: menu
+    modal: true
+    dim: false
     padding: theme.controls.menu.borderWidth
 
     implicitWidth: {