PushRuleSettingsPopup: disable save if no rule ID

2021-02-28 15:05:33 -04:00 · 2021-02-28 15:05:33 -04:00 · 41bc082044
commit 41bc082044
parent e0b7974904
2 changed files with 1 additions and 2 deletions
--- a/src/gui/Popups/PushRuleSettingsPopup/GeneralRule.qml
+++ b/src/gui/Popups/PushRuleSettingsPopup/GeneralRule.qml
@ -30,7 +30,6 @@ HColumnLayout {
            id: idField
            width: parent.width
            defaultText: rule.rule_id
-            // TODO: minimum length, check no dupe
        }
    }

--- a/src/gui/Popups/PushRuleSettingsPopup/PushRuleSettingsPopup.qml
+++ b/src/gui/Popups/PushRuleSettingsPopup/PushRuleSettingsPopup.qml
@ -79,7 +79,7 @@ HFlickableColumnPopup {
    page.footer: AutoDirectionLayout {
        ApplyButton {
            text: qsTr("Save changes")
-            enabled: true  // TODO
+            enabled: swipeView.currentItem.idField.text.trim() !== ""
            loading: saveFutureId !== ""
            onClicked: root.save()
        }