Zergling_man/moment
Zergling_man/moment
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix EventContextMenu errs if timeline has 0 events

Browse Source
This commit is contained in:
miruka 2020-09-02 14:02:12 -04:00
parent d8c006a8c8
commit 3fb64dbef5
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/gui/Pages/Chat/Timeline/EventContextMenu.qml
View File

@ -11,17 +11,17 @@ HMenu {
id: menu id: menu
property HListView eventList property HListView eventList
property int eventIndex: 0 property int eventIndex: -1
property Item eventDelegate: null // TODO: Qt 5.13: just use itemAtIndex() property Item eventDelegate: null // TODO: Qt 5.13: just use itemAtIndex()
property string hoveredLink: "" property string hoveredLink: ""
readonly property QtObject event: eventList.model.get(eventIndex) readonly property QtObject event: eventList.model.get(eventIndex) || null
readonly property bool isEncryptedMedia: readonly property bool isEncryptedMedia:
Object.keys(JSON.parse(event.media_crypt_dict)).length > 0 event && Object.keys(JSON.parse(event.media_crypt_dict)).length > 0
readonly property var mediaType: // Utils.Media.<Type> or null readonly property var mediaType: // Utils.Media.<Type> or null
event.media_http_url ? eventList.getMediaType(event) : event && event.media_http_url ? eventList.getMediaType(event) :
hoveredLink ? utils.getLinkType(hoveredLink) : hoveredLink ? utils.getLinkType(hoveredLink) :
null null
@ -37,7 +37,11 @@ HMenu {
HMenuItem { HMenuItem {
icon.name: "toggle-select-message" icon.name: "toggle-select-message"
text: event.id in eventList.checked ? qsTr("Deselect") : qsTr("Select") text:
event && event.id in eventList.checked ?
qsTr("Deselect") :
qsTr("Select")
onTriggered: eventList.toggleCheck(eventIndex) onTriggered: eventList.toggleCheck(eventIndex)
} }
@ -49,7 +53,7 @@ HMenu {
} }
HMenuItem { HMenuItem {
visible: eventIndex !== 0 visible: eventIndex > 0
icon.name: "select-until-here" icon.name: "select-until-here"
text: qsTr("Select until here") text: qsTr("Select until here")
onTriggered: eventList.checkFromLastToHere(eventIndex) onTriggered: eventList.checkFromLastToHere(eventIndex)
@ -58,14 +62,14 @@ HMenu {
HMenuItem { HMenuItem {
icon.name: "open-externally" icon.name: "open-externally"
text: qsTr("Open externally") text: qsTr("Open externally")
visible: Boolean(event.media_url) visible: Boolean(event && event.media_url)
onTriggered: eventList.openMediaExternally(event) onTriggered: eventList.openMediaExternally(event)
} }
HMenuItem { HMenuItem {
icon.name: "copy-local-path" icon.name: "copy-local-path"
text: qsTr("Copy local path") text: qsTr("Copy local path")
visible: Boolean(event.media_local_path) visible: Boolean(event && event.media_local_path)
onTriggered: onTriggered:
Clipboard.text = Clipboard.text =
event.media_local_path.replace(/^file:\/\//, "") event.media_local_path.replace(/^file:\/\//, "")
@ -90,7 +94,7 @@ HMenu {
icon.name: "copy-text" icon.name: "copy-text"
text: text:
eventList.selectedCount ? qsTr("Copy selection") : eventList.selectedCount ? qsTr("Copy selection") :
event.media_url ? qsTr("Copy filename") : event && event.media_url ? qsTr("Copy filename") :
qsTr("Copy text") qsTr("Copy text")
onTriggered: { onTriggered: {
@ -122,7 +126,7 @@ HMenu {
eventList.selectedCount ? eventList.selectedCount ?
eventList.redactableCheckedEvents : eventList.redactableCheckedEvents :
eventList.canRedact(event) ? event && eventList.canRedact(event) ?
[event] : [event] :
[] []