From 3001131ffa6bef2ba01bbf86c4188ed39572e157 Mon Sep 17 00:00:00 2001 From: miruka Date: Thu, 25 Jun 2020 11:26:21 -0400 Subject: [PATCH] Fix DeviceSection number vertical alignment --- TODO.md | 12 ++++++++---- src/gui/Pages/AccountSettings/DeviceSection.qml | 7 ++++++- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/TODO.md b/TODO.md index 99004f12..27f952fb 100644 --- a/TODO.md +++ b/TODO.md @@ -1,15 +1,19 @@ # TODO - sessions page size -- menu click-through padding to close it easily -- clear listview checked on message clear -- unregister popup/menu when destroyed without being closed - flickshortcuts - avatar upload/change component + - show scrollbars for a few secs if there's content to scroll on beginning -- can leave room with a reason? + - field/area focus line in popups weird +- clear listview checked on message clear +- unregister popup/menu when destroyed without being closed +- menu click-through padding to close it easily + +- can leave room with a reason? - use new nio `restore_login()` + - verify all popups and boxes work: enter/esc, tab focus, operations ## Refactoring diff --git a/src/gui/Pages/AccountSettings/DeviceSection.qml b/src/gui/Pages/AccountSettings/DeviceSection.qml index 8fb4fe3d..306fbb76 100644 --- a/src/gui/Pages/AccountSettings/DeviceSection.qml +++ b/src/gui/Pages/AccountSettings/DeviceSection.qml @@ -15,8 +15,8 @@ HRowLayout { readonly property int sectionTotalCount: deviceList.sectionItemCounts[section] || 0 - HCheckBox { + id: checkBox padding: theme.spacing topPadding: padding * (section === "current" ? 1 : 2) @@ -62,7 +62,10 @@ HRowLayout { .arg(sectionCheckedCount).arg(sectionTotalCount) : sectionTotalCount + topPadding: checkBox.topPadding - theme.spacing * 0.75 rightPadding: theme.spacing * 1.5 + verticalAlignment: Qt.AlignVCenter + color: section === "current" || section === "verified" ? theme.colors.positiveText : @@ -71,5 +74,7 @@ HRowLayout { theme.colors.warningText : theme.colors.errorText + + Layout.fillHeight: true } }